Debita Finance V3
Debita is a dApp focused on financial NFTs that integrates a marketplace, lending protocol, and ve3.3 management.
Details
Scope
On what chains are the smart contracts going to be deployed?
Sonic (Prev. Fantom), Base, Arbitrum & OP
If you are integrating tokens, are you allowing only whitelisted tokens to work with the codebase or any complying with the standard? Are they assumed to have certain properties, e.g. be non-reentrant? Are there any types of weird tokens you want to integrate?
We will interact with :
- any ERC20 that follows exactly the standard (eg. 18/6 decimals)
- Receipt tokens (All the interfaces from "contracts/Non-Fungible-Receipts/..")
- USDC and USDT
- Fee-on-transfer tokens will be used only in TaxTokensReceipt contract
Are there any limitations on values set by admins (or other roles) in the codebase, including restrictions on array lengths?
No
Are there any limitations on values set by admins (or other roles) in protocols you integrate with, including restrictions on array lengths?
DebitaV3Aggregator.sol::setValidNFTCollateral(address _collateral, bool status)
* _collateral = Only receipts created by DebitaDebitaV3Aggregator.sol::setOracleEnabled(address _oracle, bool status)
_oracle = Only Oracles from debita (MixOracle.sol, DebitaChainlink.sol, DebitaPyth.sol)
DebitaPyth.sol::setPriceFeeds(address tokenAddress, bytes32 priceId)
- priceId = priceID attached to the tokenAddress
DebitaChainlink.sol::setPriceFeeds(address _token, address _priceFeed)
_priceFeed = _priceFeed attached to the _token
MixOracle::setAttachedTarotPriceOracle(address uniswapV2Pair)
uniswapV2Pair = A pair where token0 is whitelisted on pyth oracle
For permissioned functions, please list all checks and requirements that will be made before calling the function.
OwnershipsContract
1. setDebitaContract
AuctionFactoryDebitaContract
setAggregator
DLOFactoryContract
setAggregatorContract
DBOFactoryContract
setAggregatorContract
incentivesContract
- setAggregatorContract
DebitaV3AggregatorContract
setValidNFTCollateral (for all deployed receipts)
Is the codebase expected to comply with any EIPs? Can there be/are there any deviations from the specification?
None of the current scope is expected to comply with EIPs.
Are there any off-chain mechanisms for the protocol (keeper bots, arbitrage bots, etc.)? We assume they won't misbehave, delay, or go offline unless specified otherwise.
Each oracle will have a MANAGER role. We will have a bot constantly monitoring the price of pairs. If there is a difference greater than 5%, the oracle will be paused until it stabilizes again.
There will be a bot that will constantly call DebitaV3Aggregator.sol::matchOffersV3(), which will listen to the created borrow and lend orders. An important point is that initially we will be the providers of this service but anyone could create a bot or manually accept the orders.
If the codebase is to be deployed on an L2, what should be the behavior of the protocol in case of sequencer issues (if applicable)? Should Sherlock assume that the Sequencer won't misbehave, including going offline?
In the event that the sequencer is down, no additional loans should be created immediately with Chainlink Oracles. For Pyth, if no updates are received within 600 seconds, the transaction will also be reverted.
What properties/invariants do you want to hold even if breaking them has a low/unknown impact?
n/a
Please discuss any design choices you made.
We have chosen to route all loans through the aggregator to maintain a consistent creation path. Borrowers will always need to create a borrow order, and lenders a lend order. The goal is to replicate the experience of a swap on a centralized exchange, where orders must be fully fulfilled.
MixOracle.sol oracle - might not be the most precise way to get the price and may have a slippage in the price of +-5%. It will be only be used in edge cases where is the last resource.
Please list any known issues and explicitly state the acceptable risks for each known issue.
N/A
We will report issues where the core protocol functionality is inaccessible for at least 7 days. Would you like to override this value?
7 days is acceptable
Please provide links to previous audits (if any).
--
Please list any relevant protocol resources.
Additional audit information.
Total Rewards
Contest Pool
Lead Senior Watson
Judging Pool
Lead Judge
32,500 USDC
25,000 USDC
3,000 USDC
Status
Scope
Start Time
End Time
Judging Rules
